While we wait for more to come from the meeting,
Stan Grant has written a brief analysis of what's happening.
We are missing a big part of this North Korea story, with the emphasis on denuclearisation or the relationship between Donald Trump and Kim Jong-un, there is not enough talk about reunification of the two Koreas.
This is what is driving Kim Jong-un, the divide between north and south is not just a physical border it is a scar on the Korean soul.
Since taking power Kim Jong-un has spoken consistently about reunification, reuniting the Korean family and finally ending the Korean War.
His weapons program has been about defence, deterrence but also significantly about leverage: how to win a seat at the table.
He has achieved that, this meeting one-on-one with an American president is something that his father Kim Jong-il sought and failed to deliver.
Years, there are issues of sanctions, economic development, but above all this is about the survival of the Kim regime in a reunited Korean Peninsula.
Remember when Kim met South Korea's president Moon Jae-in? The communique they released had reunification as the first priority: not nuclear weapons, not security guarantees, not relations with America but reunification.
As it read: South and North Korea affirmed the principle of determining the destiny of the Koreans nation on their own accord.
That is what Kim Jong-un wants: when we talk about making history this is what Kim Jong-un means.